powerpc/pseries: Delete an unnecessary kfree() call in dlpar_store()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 27 Aug 2019 11:34:02 +0000 (13:34 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 31 Jan 2021 11:35:50 +0000 (22:35 +1100)
A null pointer would be passed to a call of the function “kfree”
immediately after a call of the function “kstrdup” failed at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/b46cc4ff-a14c-0c10-0c0c-95573a960178@web.de
arch/powerpc/platforms/pseries/dlpar.c

index 16e86ba..2a783dc 100644 (file)
@@ -523,7 +523,6 @@ static ssize_t dlpar_store(struct class *class, struct class_attribute *attr,
        args = argbuf = kstrdup(buf, GFP_KERNEL);
        if (!argbuf) {
                pr_info("Could not allocate resources for DLPAR operation\n");
-               kfree(argbuf);
                return -ENOMEM;
        }