scsi: mac53c94: Do not set invalid command result
authorHannes Reinecke <hare@suse.de>
Wed, 13 Jan 2021 09:04:50 +0000 (10:04 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 23 Jan 2021 02:14:11 +0000 (21:14 -0500)
CMD_ACCEPT_MSG is an internal definition and most certainly not a SCSI
status. As the latter gets set during command completion we can drop the
assignment here.

Link: https://lore.kernel.org/r/20210113090500.129644-26-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mac53c94.c

index 43edf83..9e98977 100644 (file)
@@ -326,7 +326,6 @@ static void mac53c94_interrupt(int irq, void *dev_id)
                }
                cmd->SCp.Status = readb(&regs->fifo);
                cmd->SCp.Message = readb(&regs->fifo);
-               cmd->result = CMD_ACCEPT_MSG;
                writeb(CMD_ACCEPT_MSG, &regs->command);
                state->phase = busfreeing;
                break;