drm/amdkfd: use time_is_before_jiffies(a + b) to replace "jiffies - a > b"
authorYu Zhe <yuzhe@nfschina.com>
Thu, 28 Jul 2022 03:30:26 +0000 (11:30 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 29 Jul 2022 19:17:31 +0000 (15:17 -0400)
time_is_before_jiffies deals with timer wrapping correctly.

Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c

index a9466d1..34772fe 100644 (file)
@@ -146,7 +146,7 @@ static void interrupt_wq(struct work_struct *work)
        struct kfd_dev *dev = container_of(work, struct kfd_dev,
                                                interrupt_work);
        uint32_t ih_ring_entry[KFD_MAX_RING_ENTRY_SIZE];
-       long start_jiffies = jiffies;
+       unsigned long start_jiffies = jiffies;
 
        if (dev->device_info.ih_ring_entry_size > sizeof(ih_ring_entry)) {
                dev_err_once(dev->adev->dev, "Ring entry too small\n");
@@ -156,7 +156,7 @@ static void interrupt_wq(struct work_struct *work)
        while (dequeue_ih_ring_entry(dev, ih_ring_entry)) {
                dev->device_info.event_interrupt_class->interrupt_wq(dev,
                                                                ih_ring_entry);
-               if (jiffies - start_jiffies > HZ) {
+               if (time_is_before_jiffies(start_jiffies + HZ)) {
                        /* If we spent more than a second processing signals,
                         * reschedule the worker to avoid soft-lockup warnings
                         */