pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 2 Jan 2023 08:24:56 +0000 (12:24 +0400)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 9 Jan 2023 14:13:15 +0000 (15:13 +0100)
of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: d86f4d71e42a ("pinctrl: stm32: check irq controller availability at probe")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20230102082503.3944927-1-linmq006@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/stm32/pinctrl-stm32.c

index 1cddca5..cb33a23 100644 (file)
@@ -1382,6 +1382,7 @@ static struct irq_domain *stm32_pctrl_get_irq_domain(struct platform_device *pde
                return ERR_PTR(-ENXIO);
 
        domain = irq_find_host(parent);
+       of_node_put(parent);
        if (!domain)
                /* domain not registered yet */
                return ERR_PTR(-EPROBE_DEFER);