[parisc, s390, sparc64] no need for access_ok() in futex handling
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 16 Feb 2020 15:26:50 +0000 (10:26 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 28 Mar 2020 03:58:52 +0000 (23:58 -0400)
access_ok() is always true on those

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/parisc/include/asm/futex.h
arch/s390/include/asm/futex.h
arch/sparc/include/asm/futex_64.h

index c10cc90..c459f65 100644 (file)
@@ -39,9 +39,6 @@ arch_futex_atomic_op_inuser(int op, int oparg, int *oval, u32 __user *uaddr)
        int oldval, ret;
        u32 tmp;
 
-       if (!access_ok(uaddr, sizeof(u32)))
-               return -EFAULT;
-
        _futex_spin_lock_irqsave(uaddr, &flags);
 
        ret = -EFAULT;
index ed965c3..26f9144 100644 (file)
@@ -28,8 +28,6 @@ static inline int arch_futex_atomic_op_inuser(int op, int oparg, int *oval,
        int oldval = 0, newval, ret;
        mm_segment_t old_fs;
 
-       if (!access_ok(uaddr, sizeof(u32)))
-               return -EFAULT;
        old_fs = enable_sacf_uaccess();
        switch (op) {
        case FUTEX_OP_SET:
index 84fffaa..72de967 100644 (file)
@@ -35,8 +35,6 @@ static inline int arch_futex_atomic_op_inuser(int op, int oparg, int *oval,
 {
        int oldval = 0, ret, tem;
 
-       if (!access_ok(uaddr, sizeof(u32)))
-               return -EFAULT;
        if (unlikely((((unsigned long) uaddr) & 0x3UL)))
                return -EINVAL;