nitro_enclaves: Remove redundant 'flush_workqueue()' calls
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 12 Nov 2021 17:09:54 +0000 (18:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Nov 2021 15:10:26 +0000 (16:10 +0100)
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
-  flush_workqueue(E);
destroy_workqueue(E);

Reviewed-by: Andra Paraschiv <andraprs@amazon.com>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/d57f5c7e362837a8dfcde0d726a76b56f114e619.1636736947.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/virt/nitro_enclaves/ne_pci_dev.c

index 40b49ec..6b81e8f 100644 (file)
@@ -376,7 +376,6 @@ static void ne_teardown_msix(struct pci_dev *pdev)
        free_irq(pci_irq_vector(pdev, NE_VEC_EVENT), ne_pci_dev);
 
        flush_work(&ne_pci_dev->notify_work);
-       flush_workqueue(ne_pci_dev->event_wq);
        destroy_workqueue(ne_pci_dev->event_wq);
 
        free_irq(pci_irq_vector(pdev, NE_VEC_REPLY), ne_pci_dev);