clk: qcom: Fix return value check in apss_ipq6018_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Sun, 28 Jun 2020 02:30:55 +0000 (02:30 +0000)
committerStephen Boyd <sboyd@kernel.org>
Mon, 29 Jun 2020 21:15:34 +0000 (14:15 -0700)
In case of error, the function dev_get_regmap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 5e77b4ef1b19 ("clk: qcom: Add ipq6018 apss clock controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200628023055.50608-1-weiyongjun1@huawei.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/qcom/apss-ipq6018.c

index 004f7e1..d78ff2f 100644 (file)
@@ -87,8 +87,8 @@ static int apss_ipq6018_probe(struct platform_device *pdev)
        struct regmap *regmap;
 
        regmap = dev_get_regmap(pdev->dev.parent, NULL);
-       if (IS_ERR(regmap))
-               return PTR_ERR(regmap);
+       if (!regmap)
+               return -ENODEV;
 
        return qcom_cc_really_probe(pdev, &apss_ipq6018_desc, regmap);
 }