net/sched: sch_drr: warn about class in use while deleting
authorPedro Tammela <pctammela@mojatatu.com>
Fri, 28 Jul 2023 15:35:34 +0000 (12:35 -0300)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 1 Aug 2023 08:47:24 +0000 (10:47 +0200)
Add extack to warn that delete was rejected because
the class is still in use

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/sch_drr.c

index 1b22b3b..19901e7 100644 (file)
@@ -149,8 +149,10 @@ static int drr_delete_class(struct Qdisc *sch, unsigned long arg,
        struct drr_sched *q = qdisc_priv(sch);
        struct drr_class *cl = (struct drr_class *)arg;
 
-       if (qdisc_class_in_use(&cl->common))
+       if (qdisc_class_in_use(&cl->common)) {
+               NL_SET_ERR_MSG(extack, "DRR class is in use");
                return -EBUSY;
+       }
 
        sch_tree_lock(sch);