projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
13c1d5f
)
drm/tests: modeset: Fix drm_display_mode memory leak
author
Maxime Ripard
<mripard@kernel.org>
Tue, 8 Apr 2025 07:34:08 +0000
(09:34 +0200)
committer
Maxime Ripard
<mripard@kernel.org>
Tue, 8 Apr 2025 15:27:53 +0000
(17:27 +0200)
drm_mode_find_dmt() returns a drm_display_mode that needs to be
destroyed later one. The drm_test_pick_cmdline_res_1920_1080_60() test
never does however, which leads to a memory leak.
Let's make sure it's freed.
Reported-by: Philipp Stanner <phasta@mailbox.org>
Closes: https://lore.kernel.org/dri-devel/
a7655158a6367ac46194d57f4b7433ef0772a73e
.camel@mailbox.org/
Fixes:
8fc0380f6ba7
("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link:
https://lore.kernel.org/r/20250408-drm-kunit-drm-display-mode-memleak-v1-2-996305a2e75a@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/tests/drm_client_modeset_test.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/tests/drm_client_modeset_test.c
b/drivers/gpu/drm/tests/drm_client_modeset_test.c
index
7516f6c
..
3e9518d
100644
(file)
--- a/
drivers/gpu/drm/tests/drm_client_modeset_test.c
+++ b/
drivers/gpu/drm/tests/drm_client_modeset_test.c
@@
-95,6
+95,9
@@
static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
expected_mode = drm_mode_find_dmt(priv->drm, 1920, 1080, 60, false);
KUNIT_ASSERT_NOT_NULL(test, expected_mode);
+ ret = drm_kunit_add_mode_destroy_action(test, expected_mode);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
KUNIT_ASSERT_TRUE(test,
drm_mode_parse_command_line_for_connector(cmdline,
connector,