drm/amdgpu: Fix amdgpu_ip_block_hw_fini()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 24 Oct 2024 08:17:16 +0000 (11:17 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 24 Oct 2024 22:07:10 +0000 (18:07 -0400)
This NULL check is reversed so the function doesn't work.

Fixes: dad01f93f432 ("drm/amdgpu: validate hw_fini before function call")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/f4fc849e-4e76-4448-8657-caa4c69910b0@stanley.mountain
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index b377bd9..a7b55d6 100644 (file)
@@ -3308,7 +3308,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block)
 {
        int r;
 
-       if (ip_block->version->funcs->hw_fini) {
+       if (!ip_block->version->funcs->hw_fini) {
                DRM_ERROR("hw_fini of IP block <%s> not defined\n",
                          ip_block->version->funcs->name);
        } else {