pmdomain: imx: gpcv2: replace dev_err() with dev_err_probe()
authorDario Binacchi <dario.binacchi@amarulasolutions.com>
Fri, 25 Oct 2024 16:03:56 +0000 (18:03 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 31 Oct 2024 10:41:20 +0000 (11:41 +0100)
The patch standardizes the probe() code by replacing the two occurrences
of dev_err() with dev_err_probe(). Indeed, dev_err_probe() was used in all
other error paths of the probe() function.
Note that dev_err_probe() has advantages even if the error code is not
EPROBE_DEFER, such as the symbolic output of the error code. Therefore,
it should generally be preferred over dev_err().

Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Message-ID: <20241025160430.4113467-1-dario.binacchi@amarulasolutions.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/imx/gpcv2.c

index 963d61c..6e6ecbf 100644 (file)
@@ -1356,7 +1356,7 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
 
        ret = pm_genpd_init(&domain->genpd, NULL, true);
        if (ret) {
-               dev_err(domain->dev, "Failed to init power domain\n");
+               dev_err_probe(domain->dev, ret, "Failed to init power domain\n");
                goto out_domain_unmap;
        }
 
@@ -1367,7 +1367,7 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
        ret = of_genpd_add_provider_simple(domain->dev->of_node,
                                           &domain->genpd);
        if (ret) {
-               dev_err(domain->dev, "Failed to add genpd provider\n");
+               dev_err_probe(domain->dev, ret, "Failed to add genpd provider\n");
                goto out_genpd_remove;
        }