IB/rxe: avoid calling WARN_ON_ONCE twice
authorZhu Yanjun <yanjun.zhu@oracle.com>
Thu, 17 May 2018 08:55:22 +0000 (04:55 -0400)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 17 May 2018 15:16:14 +0000 (09:16 -0600)
In the exit branch, WARN_ON_ONCE is called to show stack. So it is
not necessary to call WARN_ON_ONCE before going to exit.

Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/sw/rxe/rxe_comp.c

index a285978..98d470d 100644 (file)
@@ -659,7 +659,6 @@ int rxe_completer(void *arg)
                            qp->qp_timeout_jiffies)
                                mod_timer(&qp->retrans_timer,
                                          jiffies + qp->qp_timeout_jiffies);
-                       WARN_ON_ONCE(skb);
                        goto exit;
 
                case COMPST_ERROR_RETRY:
@@ -673,7 +672,6 @@ int rxe_completer(void *arg)
 
                        /* there is nothing to retry in this case */
                        if (!wqe || (wqe->state == wqe_state_posted)) {
-                               WARN_ON_ONCE(skb);
                                goto exit;
                        }
 
@@ -702,7 +700,6 @@ int rxe_completer(void *arg)
                                        skb = NULL;
                                }
 
-                               WARN_ON_ONCE(skb);
                                goto exit;
 
                        } else {
@@ -746,7 +743,6 @@ int rxe_completer(void *arg)
                                skb = NULL;
                        }
 
-                       WARN_ON_ONCE(skb);
                        goto exit;
                }
        }