misc: ti-st: st_kim: use 'time_left' variable with wait_for_completion_interruptible_...
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 4 Jun 2024 21:22:39 +0000 (23:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2024 14:40:18 +0000 (16:40 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_interruptible_timeout() causing patterns like:

timeout = wait_for_completion_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240604212240.4529-5-wsa+renesas@sang-engineering.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti-st/st_kim.c

index c4f963c..ff172cf 100644 (file)
@@ -198,7 +198,7 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name)
 {
        unsigned short version = 0, chip = 0, min_ver = 0, maj_ver = 0;
        static const char read_ver_cmd[] = { 0x01, 0x01, 0x10, 0x00 };
-       long timeout;
+       long time_left;
 
        pr_debug("%s", __func__);
 
@@ -208,11 +208,11 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name)
                return -EIO;
        }
 
-       timeout = wait_for_completion_interruptible_timeout(
+       time_left = wait_for_completion_interruptible_timeout(
                &kim_gdata->kim_rcvd, msecs_to_jiffies(CMD_RESP_TIME));
-       if (timeout <= 0) {
+       if (time_left <= 0) {
                pr_err(" waiting for ver info- timed out or received signal");
-               return timeout ? -ERESTARTSYS : -ETIMEDOUT;
+               return time_left ? -ERESTARTSYS : -ETIMEDOUT;
        }
        reinit_completion(&kim_gdata->kim_rcvd);
        /*