media: allegro: Fix some NULL vs IS_ERR() checks in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Jun 2020 14:30:07 +0000 (16:30 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jul 2020 10:32:32 +0000 (12:32 +0200)
The devm_ioremap() function doesn't return error pointers, it returns
NULL on error.

Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/allegro-dvt/allegro-core.c

index 70f133a..3ed66aa 100644 (file)
@@ -3065,9 +3065,9 @@ static int allegro_probe(struct platform_device *pdev)
                return -EINVAL;
        }
        regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
-       if (IS_ERR(regs)) {
+       if (!regs) {
                dev_err(&pdev->dev, "failed to map registers\n");
-               return PTR_ERR(regs);
+               return -ENOMEM;
        }
        dev->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
                                            &allegro_regmap_config);
@@ -3085,9 +3085,9 @@ static int allegro_probe(struct platform_device *pdev)
        sram_regs = devm_ioremap(&pdev->dev,
                                 sram_res->start,
                                 resource_size(sram_res));
-       if (IS_ERR(sram_regs)) {
+       if (!sram_regs) {
                dev_err(&pdev->dev, "failed to map sram\n");
-               return PTR_ERR(sram_regs);
+               return -ENOMEM;
        }
        dev->sram = devm_regmap_init_mmio(&pdev->dev, sram_regs,
                                          &allegro_sram_config);