drm/xe/pcode: fix pcode error check
authorMatthew Auld <matthew.auld@intel.com>
Thu, 12 Jan 2023 16:34:09 +0000 (16:34 +0000)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 12 Dec 2023 19:06:00 +0000 (14:06 -0500)
On DG2 we are now getting:

[  104.456607] xe 0000:03:00.0: [drm] *ERROR* PCODE timeout, retrying with preemption disabled

Looks like we just need to invert the error check for
xe_pcode_try_request(), which returns zero on success.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_pcode.c

index 39712e8..1a76fe4 100644 (file)
@@ -155,7 +155,7 @@ int xe_pcode_request(struct xe_gt *gt, u32 mbox, u32 request,
 
        ret = xe_pcode_try_request(gt, mbox, request, reply_mask, reply, &status,
                                   false, timeout_base_ms * 1000);
-       if (ret)
+       if (!ret)
                goto out;
 
        /*