media: mtk-jpeg: Remove cancel worker in mtk_jpeg_remove to avoid the crash of multi...
authorZheng Wang <zyytlz.wz@163.com>
Mon, 6 Nov 2023 14:48:09 +0000 (15:48 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 23 Nov 2023 12:37:04 +0000 (13:37 +0100)
This patch reverts commit c677d7ae8314
("media: mtk-jpeg: Fix use after free bug due to uncanceled work").
The job_timeout_work is initialized only for
the single-core JPEG device so it will cause the crash for multi-core
JPEG devices.

Fix it by removing the cancel_delayed_work_sync function.

Fixes: c677d7ae8314 ("media: mtk-jpeg: Fix use after free bug due to uncanceled work")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c

index 73a063b..7c2e6a2 100644 (file)
@@ -1402,7 +1402,6 @@ static void mtk_jpeg_remove(struct platform_device *pdev)
 {
        struct mtk_jpeg_dev *jpeg = platform_get_drvdata(pdev);
 
-       cancel_delayed_work_sync(&jpeg->job_timeout_work);
        pm_runtime_disable(&pdev->dev);
        video_unregister_device(jpeg->vdev);
        v4l2_m2m_release(jpeg->m2m_dev);