ceph: remove unnecessary assignment in ceph_pre_init_acls()
authorChengguang Xu <cgxu519@gmx.com>
Fri, 17 Aug 2018 14:05:31 +0000 (22:05 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 27 Jan 2020 15:53:39 +0000 (16:53 +0100)
ceph_pagelist_encode_string() will not fail in reserved case,
also, we do not check err code here, so remove unnecessary
assignment.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/acl.c

index aa55f41..26be652 100644 (file)
@@ -222,8 +222,8 @@ int ceph_pre_init_acls(struct inode *dir, umode_t *mode,
                err = ceph_pagelist_reserve(pagelist, len + val_size2 + 8);
                if (err)
                        goto out_err;
-               err = ceph_pagelist_encode_string(pagelist,
-                                                 XATTR_NAME_POSIX_ACL_DEFAULT, len);
+               ceph_pagelist_encode_string(pagelist,
+                                         XATTR_NAME_POSIX_ACL_DEFAULT, len);
                err = posix_acl_to_xattr(&init_user_ns, default_acl,
                                         tmp_buf, val_size2);
                if (err < 0)