staging: vchiq_core: fix logic redundancy in parse_open
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Tue, 20 Nov 2018 14:53:48 +0000 (15:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 09:13:37 +0000 (10:13 +0100)
We update sync to reflect that the firmware version is compatible with
that option. We don't need to check both of them again further down the
code.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

index a45cdd0..5ee667d 100644 (file)
@@ -1461,9 +1461,7 @@ parse_open(VCHIQ_STATE_T *state, VCHIQ_HEADER_T *header)
                                        service->sync = 0;
 
                                /* Acknowledge the OPEN */
-                               if (service->sync &&
-                                   (state->version_common >=
-                                    VCHIQ_VERSION_SYNCHRONOUS_MODE)) {
+                               if (service->sync) {
                                        if (queue_message_sync(
                                                state,
                                                NULL,