misc: bcm-vk: unlock on error in bcm_to_h_msg_dequeue()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 1 Feb 2021 12:22:07 +0000 (15:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Feb 2021 14:57:57 +0000 (15:57 +0100)
Unlock before returning on this error path.

Fixes: 111d746bb476 ("misc: bcm-vk: add VK messaging support")
Acked-by: Desmond Yan <desmond.yan@broadcom.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YBfyb+jU5lDUe+5g@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/bcm-vk/bcm_vk_msg.c

index a363e2e..f40cf08 100644 (file)
@@ -855,7 +855,8 @@ s32 bcm_to_h_msg_dequeue(struct bcm_vk *vk)
                                 * that is fatal.
                                 */
                                dev_crit(dev, "Kernel mem allocation failure.\n");
-                               return -ENOMEM;
+                               total = -ENOMEM;
+                               goto idx_err;
                        }
 
                        /* flush rd pointer after a message is dequeued */