dm: fix alloc_dax error handling in alloc_dev
authorChristoph Hellwig <hch@lst.de>
Mon, 29 Nov 2021 10:21:35 +0000 (11:21 +0100)
committerDan Williams <dan.j.williams@intel.com>
Sat, 4 Dec 2021 16:58:50 +0000 (08:58 -0800)
Make sure ->dax_dev is NULL on error so that the cleanup path doesn't
trip over an ERR_PTR.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211129102203.2243509-2-hch@lst.de
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/md/dm.c

index 662742a..acc84dc 100644 (file)
@@ -1786,8 +1786,10 @@ static struct mapped_device *alloc_dev(int minor)
        if (IS_ENABLED(CONFIG_DAX_DRIVER)) {
                md->dax_dev = alloc_dax(md, md->disk->disk_name,
                                        &dm_dax_ops, 0);
-               if (IS_ERR(md->dax_dev))
+               if (IS_ERR(md->dax_dev)) {
+                       md->dax_dev = NULL;
                        goto bad;
+               }
        }
 
        format_dev_t(md->name, MKDEV(_major, minor));