media: ti: cal: Constify struct media_entity_operations
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 24 Jun 2024 04:40:38 +0000 (06:40 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 9 Aug 2024 05:56:38 +0000 (07:56 +0200)
'struct media_entity_operations' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text    data     bss     dec     hex filename
  20694    1394      32   22120    5668 drivers/media/platform/ti/cal/cal-camerarx.o

After:
=====
   text    data     bss     dec     hex filename
  20726    1362      32   22120    5668 drivers/media/platform/ti/cal/cal-camerarx.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/ti/cal/cal-camerarx.c

index 4afc2ad..42dfe08 100644 (file)
@@ -798,7 +798,7 @@ static const struct v4l2_subdev_internal_ops cal_camerarx_internal_ops = {
        .init_state = cal_camerarx_sd_init_state,
 };
 
-static struct media_entity_operations cal_camerarx_media_ops = {
+static const struct media_entity_operations cal_camerarx_media_ops = {
        .link_validate = v4l2_subdev_link_validate,
 };