pinctrl: Unconditionally assign .request()/.free()
authorThierry Reding <treding@nvidia.com>
Wed, 1 Apr 2020 20:05:27 +0000 (22:05 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 2 Apr 2020 07:17:16 +0000 (09:17 +0200)
The gpiochip_generic_request() and gpiochip_generic_free() functions can
now deal properly with chips that don't have any pin-ranges defined, so
they can be assigned unconditionally.

Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20200401200527.2982450-2-thierry.reding@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-ingenic.c

index 96f04d1..bc7f6df 100644 (file)
@@ -2278,11 +2278,8 @@ static int __init ingenic_gpio_probe(struct ingenic_pinctrl *jzpc,
        jzgc->gc.direction_input = ingenic_gpio_direction_input;
        jzgc->gc.direction_output = ingenic_gpio_direction_output;
        jzgc->gc.get_direction = ingenic_gpio_get_direction;
-
-       if (of_property_read_bool(node, "gpio-ranges")) {
-               jzgc->gc.request = gpiochip_generic_request;
-               jzgc->gc.free = gpiochip_generic_free;
-       }
+       jzgc->gc.request = gpiochip_generic_request;
+       jzgc->gc.free = gpiochip_generic_free;
 
        jzgc->irq = irq_of_parse_and_map(node, 0);
        if (!jzgc->irq)