pwm: Return -EINVAL for old-style drivers without .set_polarity callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 1 Mar 2021 18:23:07 +0000 (19:23 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Mon, 22 Mar 2021 10:55:20 +0000 (11:55 +0100)
Since commit 2b1c1a5d5148 ("pwm: Use -EINVAL for unsupported polarity")
all drivers implementing the apply callback are unified to return
-EINVAL if an unsupported polarity is requested. Do the same in the
compat code for old-style drivers.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/core.c

index 8904eaa..25ee06a 100644 (file)
@@ -596,7 +596,7 @@ int pwm_apply_state(struct pwm_device *pwm, const struct pwm_state *state)
                 */
                if (state->polarity != pwm->state.polarity) {
                        if (!chip->ops->set_polarity)
-                               return -ENOTSUPP;
+                               return -EINVAL;
 
                        /*
                         * Changing the polarity of a running PWM is