misc: eeprom: eeprom_93cx6: Switch to BIT() macro
authorParker Newman <pnewman@connecttech.com>
Wed, 2 Oct 2024 15:12:34 +0000 (11:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Oct 2024 06:42:03 +0000 (08:42 +0200)
Use the BIT() macro rather than (1 << (i - 1)).

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Parker Newman <pnewman@connecttech.com>
Link: https://lore.kernel.org/r/f40d21d284816a62003975e237a58b489d77c7d4.1727880931.git.pnewman@connecttech.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/eeprom_93cx6.c

index 4c9827f..e6f0e0f 100644 (file)
@@ -8,6 +8,7 @@
  * Supported chipsets: 93c46 & 93c66.
  */
 
+#include <linux/bits.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/delay.h>
@@ -102,7 +103,7 @@ static void eeprom_93cx6_write_bits(struct eeprom_93cx6 *eeprom,
                /*
                 * Check if this bit needs to be set.
                 */
-               eeprom->reg_data_in = !!(data & (1 << (i - 1)));
+               eeprom->reg_data_in = !!(data & BIT(i - 1));
 
                /*
                 * Write the bit to the eeprom register.
@@ -152,7 +153,7 @@ static void eeprom_93cx6_read_bits(struct eeprom_93cx6 *eeprom,
                 * Read if the bit has been set.
                 */
                if (eeprom->reg_data_out)
-                       buf |= (1 << (i - 1));
+                       buf |= BIT(i - 1);
 
                eeprom_93cx6_pulse_low(eeprom);
        }