ionic: fire watchdog again after fw_down
authorShannon Nelson <snelson@pensando.io>
Fri, 27 Aug 2021 18:55:07 +0000 (11:55 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Aug 2021 10:23:09 +0000 (11:23 +0100)
In some cases of fw_down it was called because there was a
fw_generation change, and the firmware is already back up.
In order to keep the down time to a minimum, don't wait for
the next watchdog polling cycle, fire another watchdog off
as soon as we can - an out-of-cycle check won't hurt, and
may well speed up the recovery.

Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index e494d6b..df01370 100644 (file)
@@ -93,10 +93,17 @@ static void ionic_lif_deferred_work(struct work_struct *work)
                        ionic_link_status_check(lif);
                        break;
                case IONIC_DW_TYPE_LIF_RESET:
-                       if (w->fw_status)
+                       if (w->fw_status) {
                                ionic_lif_handle_fw_up(lif);
-                       else
+                       } else {
                                ionic_lif_handle_fw_down(lif);
+
+                               /* Fire off another watchdog to see
+                                * if the FW is already back rather than
+                                * waiting another whole cycle
+                                */
+                               mod_timer(&lif->ionic->watchdog_timer, jiffies + 1);
+                       }
                        break;
                default:
                        break;