NFSD: Clean up nfsd4_encode_access()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 9 Oct 2023 18:29:43 +0000 (14:29 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 16 Oct 2023 16:44:35 +0000 (12:44 -0400)
Convert nfsd4_encode_access() to use modern XDR utility functions.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index a3f0496..5f56f8c 100644 (file)
@@ -3908,14 +3908,14 @@ nfsd4_encode_access(struct nfsd4_compoundres *resp, __be32 nfserr,
 {
        struct nfsd4_access *access = &u->access;
        struct xdr_stream *xdr = resp->xdr;
-       __be32 *p;
+       __be32 status;
 
-       p = xdr_reserve_space(xdr, 8);
-       if (!p)
-               return nfserr_resource;
-       *p++ = cpu_to_be32(access->ac_supported);
-       *p++ = cpu_to_be32(access->ac_resp_access);
-       return 0;
+       /* supported */
+       status = nfsd4_encode_uint32_t(xdr, access->ac_supported);
+       if (status != nfs_ok)
+               return status;
+       /* access */
+       return nfsd4_encode_uint32_t(xdr, access->ac_resp_access);
 }
 
 static __be32 nfsd4_encode_bind_conn_to_session(struct nfsd4_compoundres *resp, __be32 nfserr,