gpio: shared: fix auxiliary device cleanup order
authorBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Sat, 6 Dec 2025 11:53:55 +0000 (12:53 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Tue, 9 Dec 2025 06:16:45 +0000 (07:16 +0100)
Dropping the last reference to the internal struct device should be the
last thing we do so delete the device first and then uninit it which
also involves the final put_device().

Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
Link: https://lore.kernel.org/r/20251206-gpio-shared-teardown-fixes-v1-3-35ac458cfce1@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpiolib-shared.c

index 4084a28..2d3b0c3 100644 (file)
@@ -415,8 +415,8 @@ static void gpio_shared_remove_adev(struct auxiliary_device *adev)
 {
        lockdep_assert_held(&gpio_shared_lock);
 
-       auxiliary_device_uninit(adev);
        auxiliary_device_delete(adev);
+       auxiliary_device_uninit(adev);
 }
 
 int gpio_device_setup_shared(struct gpio_device *gdev)