netfilter: x_tables: set module owner for icmp(6) matches
authorFlorian Westphal <fw@strlen.de>
Wed, 4 Jul 2018 18:25:32 +0000 (20:25 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 5 Jul 2018 09:45:11 +0000 (11:45 +0200)
nft_compat relies on xt_request_find_match to increment
refcount of the module that provides the match/target.

The (builtin) icmp matches did't set the module owner so it
was possible to rmmod ip(6)tables while icmp extensions were still in use.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/ip_tables.c
net/ipv6/netfilter/ip6_tables.c

index ca0dad9..e77872c 100644 (file)
@@ -1898,6 +1898,7 @@ static struct xt_match ipt_builtin_mt[] __read_mostly = {
                .checkentry = icmp_checkentry,
                .proto      = IPPROTO_ICMP,
                .family     = NFPROTO_IPV4,
+               .me         = THIS_MODULE,
        },
 };
 
index 7eab959..daf2e9e 100644 (file)
@@ -1909,6 +1909,7 @@ static struct xt_match ip6t_builtin_mt[] __read_mostly = {
                .checkentry = icmp6_checkentry,
                .proto      = IPPROTO_ICMPV6,
                .family     = NFPROTO_IPV6,
+               .me         = THIS_MODULE,
        },
 };