projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
83a458e
)
fpga: xilinx-pr-decoupler: Use readl wrapper instead of pure readl
author
Michal Simek
<michal.simek@amd.com>
Tue, 21 Mar 2023 15:33:23 +0000
(16:33 +0100)
committer
Xu Yilun
<yilun.xu@intel.com>
Sat, 25 Mar 2023 07:35:12 +0000
(15:35 +0800)
Driver has IO wrappers but xlnx_pr_decouple_read() is not used and readl is
used instead which is just wrong.
It is also generating sparse issue that xlnx_pr_decouple_read() is unused.
Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link:
https://lore.kernel.org/r/0381e4e8061c2fee182a104768e84feff3a82d25.1679412800.git.michal.simek@amd.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
drivers/fpga/xilinx-pr-decoupler.c
patch
|
blob
|
history
diff --git
a/drivers/fpga/xilinx-pr-decoupler.c
b/drivers/fpga/xilinx-pr-decoupler.c
index
2d9c491
..
b76d854
100644
(file)
--- a/
drivers/fpga/xilinx-pr-decoupler.c
+++ b/
drivers/fpga/xilinx-pr-decoupler.c
@@
-69,7
+69,7
@@
static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
if (err)
return err;
- status =
readl(priv->io_base
);
+ status =
xlnx_pr_decouple_read(priv, CTRL_OFFSET
);
clk_disable(priv->clk);