i2c: pxa: Use dev_err_probe in probe function
authorLiao Chang <liaochang1@huawei.com>
Tue, 8 Aug 2023 01:29:51 +0000 (09:29 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 10 Aug 2023 08:13:30 +0000 (10:13 +0200)
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed message includes the return value and also handles
-EPROBE_DEFER nicely.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20230808012954.1643834-7-liaochang1@huawei.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-pxa.c

index 65a18d7..2eae12c 100644 (file)
@@ -1404,10 +1404,9 @@ static int i2c_pxa_probe(struct platform_device *dev)
        strscpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name));
 
        i2c->clk = devm_clk_get(&dev->dev, NULL);
-       if (IS_ERR(i2c->clk)) {
-               dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk));
-               return PTR_ERR(i2c->clk);
-       }
+       if (IS_ERR(i2c->clk))
+               return dev_err_probe(&dev->dev, PTR_ERR(i2c->clk),
+                                    "failed to get the clk\n");
 
        i2c->reg_ibmr = i2c->reg_base + pxa_reg_layout[i2c_type].ibmr;
        i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr;