cppc_cpufreq: use policy->cpu as driver of frequency setting
authorIonela Voinescu <ionela.voinescu@arm.com>
Mon, 14 Dec 2020 12:38:20 +0000 (12:38 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 15 Dec 2020 18:19:31 +0000 (19:19 +0100)
Considering only the currently supported coordination types (ANY, HW,
NONE), this change only makes a difference for the ANY type, when
policy->cpu is hotplugged out. In that case the new policy->cpu will
be different from ((struct cppc_cpudata *)policy->driver_data)->cpu.

While in this case the controls of *ANY* CPU could be used to drive
frequency changes, it's more consistent to use policy->cpu as the
leading CPU, as used in all other cppc_cpufreq functions. Additionally,
the debug prints in cppc_set_perf() would no longer create confusion
when referring to a CPU that is hotplugged out.

Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cppc_cpufreq.c

index 7cc9bd8..2700fc7 100644 (file)
@@ -150,6 +150,7 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
                                   unsigned int relation)
 {
        struct cppc_cpudata *cpu_data = all_cpu_data[policy->cpu];
+       unsigned int cpu = policy->cpu;
        struct cpufreq_freqs freqs;
        u32 desired_perf;
        int ret = 0;
@@ -164,12 +165,12 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
        freqs.new = target_freq;
 
        cpufreq_freq_transition_begin(policy, &freqs);
-       ret = cppc_set_perf(cpu_data->cpu, &cpu_data->perf_ctrls);
+       ret = cppc_set_perf(cpu, &cpu_data->perf_ctrls);
        cpufreq_freq_transition_end(policy, &freqs, ret != 0);
 
        if (ret)
                pr_debug("Failed to set target on CPU:%d. ret:%d\n",
-                        cpu_data->cpu, ret);
+                        cpu, ret);
 
        return ret;
 }