mfd: rt5033: Fix missing regmap_del_irq_chip()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Wed, 30 Oct 2024 15:41:06 +0000 (23:41 +0800)
committerLee Jones <lee@kernel.org>
Wed, 6 Nov 2024 08:04:24 +0000 (08:04 +0000)
Fix missing call to regmap_del_irq_chip() in error handling path by
using devm_regmap_add_irq_chip().

Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1730302867-8391-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/rt5033.c

index 7e23ab3..84ebc96 100644 (file)
@@ -81,8 +81,8 @@ static int rt5033_i2c_probe(struct i2c_client *i2c)
        chip_rev = dev_id & RT5033_CHIP_REV_MASK;
        dev_info(&i2c->dev, "Device found (rev. %d)\n", chip_rev);
 
-       ret = regmap_add_irq_chip(rt5033->regmap, rt5033->irq,
-                       IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+       ret = devm_regmap_add_irq_chip(rt5033->dev, rt5033->regmap,
+                       rt5033->irq, IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
                        0, &rt5033_irq_chip, &rt5033->irq_data);
        if (ret) {
                dev_err(&i2c->dev, "Failed to request IRQ %d: %d\n",