drm/amdgpu: disable runtime pm on several sienna cichlid cards(v2)
authorGuchun Chen <guchun.chen@amd.com>
Wed, 27 Apr 2022 07:51:02 +0000 (15:51 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Apr 2022 21:46:42 +0000 (17:46 -0400)
Disable runtime power management on several sienna cichlid
cards, otherwise SMU will possibly fail to be resumed from
runtime suspend. Will drop this after a clean solution between
kernel driver and SMU FW is available.

amdgpu 0000:63:00.0: amdgpu: GECC is enabled
amdgpu 0000:63:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available
amdgpu 0000:63:00.0: amdgpu: SMU is resuming...
amdgpu 0000:63:00.0: amdgpu: SMU: I'm not done with your command: SMN_C2PMSG_66:0x0000000E SMN_C2PMSG_82:0x00000080
amdgpu 0000:63:00.0: amdgpu: Failed to SetDriverDramAddr!
amdgpu 0000:63:00.0: amdgpu: Failed to setup smc hw!
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <smu> failed -62
amdgpu 0000:63:00.0: amdgpu: amdgpu_device_ip_resume failed (-62)

v2: seperate to a function.

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

index 6b626c2..51bb977 100644 (file)
 #include "amdgpu_display.h"
 #include "amdgpu_ras.h"
 
+static void amdgpu_runtime_pm_quirk(struct amdgpu_device *adev)
+{
+       /*
+        * Add below quirk on several sienna_cichlid cards to disable
+        * runtime pm to fix EMI failures.
+        */
+       if (((adev->pdev->device == 0x73A1) && (adev->pdev->revision == 0x00)) ||
+           ((adev->pdev->device == 0x73BF) && (adev->pdev->revision == 0xCF)))
+               adev->runpm = false;
+}
+
 void amdgpu_unregister_gpu_instance(struct amdgpu_device *adev)
 {
        struct amdgpu_gpu_instance *gpu_instance;
@@ -180,6 +191,9 @@ int amdgpu_driver_load_kms(struct amdgpu_device *adev, unsigned long flags)
                 */
                if (adev->is_fw_fb)
                        adev->runpm = false;
+
+               amdgpu_runtime_pm_quirk(adev);
+
                if (adev->runpm)
                        dev_info(adev->dev, "Using BACO for runtime pm\n");
        }