crypto: starfive - remove unneeded crypto_engine_stop() call
authorOvidiu Panait <ovidiu.panait.oss@gmail.com>
Sun, 20 Oct 2024 19:25:32 +0000 (22:25 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 28 Oct 2024 10:33:11 +0000 (18:33 +0800)
The explicit crypto_engine_stop() call is not needed, as it is already
called internally by crypto_engine_exit().

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/starfive/jh7110-cryp.c

index 45e5e83..42114e9 100644 (file)
@@ -151,7 +151,7 @@ static int starfive_cryp_probe(struct platform_device *pdev)
 
        ret = starfive_aes_register_algs();
        if (ret)
-               goto err_algs_aes;
+               goto err_engine_start;
 
        ret = starfive_hash_register_algs();
        if (ret)
@@ -167,8 +167,6 @@ err_algs_rsa:
        starfive_hash_unregister_algs();
 err_algs_hash:
        starfive_aes_unregister_algs();
-err_algs_aes:
-       crypto_engine_stop(cryp->engine);
 err_engine_start:
        crypto_engine_exit(cryp->engine);
 err_engine:
@@ -193,7 +191,6 @@ static void starfive_cryp_remove(struct platform_device *pdev)
        starfive_hash_unregister_algs();
        starfive_rsa_unregister_algs();
 
-       crypto_engine_stop(cryp->engine);
        crypto_engine_exit(cryp->engine);
 
        starfive_dma_cleanup(cryp);