wcn36xx: Use platform_get_irq_byname() to get the interrupt
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Fri, 24 Dec 2021 19:26:24 +0000 (19:26 +0000)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 17 Jan 2022 12:44:08 +0000 (14:44 +0200)
platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq_byname().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20211224192626.15843-7-prabhakar.mahadev-lad.rj@bp.renesas.com
drivers/net/wireless/ath/wcn36xx/main.c

index 9575d73..bd334a3 100644 (file)
@@ -1446,25 +1446,20 @@ static int wcn36xx_platform_get_resources(struct wcn36xx *wcn,
 {
        struct device_node *mmio_node;
        struct device_node *iris_node;
-       struct resource *res;
        int index;
        int ret;
 
        /* Set TX IRQ */
-       res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "tx");
-       if (!res) {
-               wcn36xx_err("failed to get tx_irq\n");
-               return -ENOENT;
-       }
-       wcn->tx_irq = res->start;
+       ret = platform_get_irq_byname(pdev, "tx");
+       if (ret < 0)
+               return ret;
+       wcn->tx_irq = ret;
 
        /* Set RX IRQ */
-       res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "rx");
-       if (!res) {
-               wcn36xx_err("failed to get rx_irq\n");
-               return -ENOENT;
-       }
-       wcn->rx_irq = res->start;
+       ret = platform_get_irq_byname(pdev, "rx");
+       if (ret < 0)
+               return ret;
+       wcn->rx_irq = ret;
 
        /* Acquire SMSM tx enable handle */
        wcn->tx_enable_state = qcom_smem_state_get(&pdev->dev,