pinctrl: rockchip: remove redundant check
authorHeiko Stübner <heiko@sntech.de>
Tue, 15 Oct 2013 23:08:11 +0000 (01:08 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 16 Oct 2013 13:33:53 +0000 (15:33 +0200)
The check limiting bias options to supported ones is already
done thru rockchip_pinconf_pull_valid. Therefore this check is
redundant and can be removed.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-rockchip.c

index efca116..91027dd 100644 (file)
@@ -424,12 +424,6 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
 
        switch (ctrl->type) {
        case RK2928:
-               if (pull != PIN_CONFIG_BIAS_PULL_PIN_DEFAULT &&
-                                       pull != PIN_CONFIG_BIAS_DISABLE) {
-                       dev_err(info->dev, "only PIN_DEFAULT and DISABLE allowed\n");
-                       return -EINVAL;
-               }
-
                ctrl->pull_calc_reg(bank, pin_num, &reg, &bit);
 
                spin_lock_irqsave(&bank->slock, flags);