Input: serio_raw - fix uninitialized variable bug
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 21 Oct 2024 07:04:05 +0000 (00:04 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 21 Oct 2024 07:12:11 +0000 (00:12 -0700)
Recent conversion of the driver to use guard notation for locks and
other resources introduced a bug: "written" variable that is supposed to
hold number of bytes successfully written was not initialized.

Fix it by initializing the variable with 0.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410201730.ItNhUTIv-lkp@intel.com/
Fixes: 5b53a9d40c4f ("Input: serio_raw - use guard notation for locks and other resources")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/serio_raw.c

index e058fef..4d63950 100644 (file)
@@ -185,7 +185,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer,
 {
        struct serio_raw_client *client = file->private_data;
        struct serio_raw *serio_raw = client->serio_raw;
-       int written;
+       int written = 0;
        unsigned char c;
 
        scoped_guard(mutex_intr, &serio_raw_mutex) {