soc/tegra: fuse: Trivial clean-up of tegra_init_revision()
authorJon Hunter <jonathanh@nvidia.com>
Fri, 17 Apr 2020 12:39:49 +0000 (13:39 +0100)
committerThierry Reding <treding@nvidia.com>
Tue, 21 Apr 2020 22:07:27 +0000 (00:07 +0200)
Clean-up the tegra_init_revision() function by removing the 'rev'
variable which is not needed and use the newly added helper function
tegra_get_minor_rev() to get the minor revision.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/soc/tegra/fuse/tegra-apbmisc.c

index 44a154c..3cdd69d 100644 (file)
@@ -75,36 +75,32 @@ static const struct of_device_id apbmisc_match[] __initconst = {
 
 void __init tegra_init_revision(void)
 {
-       u32 id, chip_id, minor_rev;
-       int rev;
+       u8 chip_id, minor_rev;
 
-       id = tegra_read_chipid();
-       chip_id = (id >> 8) & 0xff;
-       minor_rev = (id >> 16) & 0xf;
+       chip_id = tegra_get_chip_id();
+       minor_rev = tegra_get_minor_rev();
 
        switch (minor_rev) {
        case 1:
-               rev = TEGRA_REVISION_A01;
+               tegra_sku_info.revision = TEGRA_REVISION_A01;
                break;
        case 2:
-               rev = TEGRA_REVISION_A02;
+               tegra_sku_info.revision = TEGRA_REVISION_A02;
                break;
        case 3:
                if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
                                           tegra_fuse_read_spare(19)))
-                       rev = TEGRA_REVISION_A03p;
+                       tegra_sku_info.revision = TEGRA_REVISION_A03p;
                else
-                       rev = TEGRA_REVISION_A03;
+                       tegra_sku_info.revision = TEGRA_REVISION_A03;
                break;
        case 4:
-               rev = TEGRA_REVISION_A04;
+               tegra_sku_info.revision = TEGRA_REVISION_A04;
                break;
        default:
-               rev = TEGRA_REVISION_UNKNOWN;
+               tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
        }
 
-       tegra_sku_info.revision = rev;
-
        tegra_sku_info.sku_id = tegra_fuse_read_early(FUSE_SKU_INFO);
 }