watchdog: stpmic1_wdt: Use 'dev' instead of dereferencing it repeatedly
authorGuenter Roeck <linux@roeck-us.net>
Tue, 9 Apr 2019 17:23:59 +0000 (10:23 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:29 +0000 (21:02 +0200)
Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/stpmic1_wdt.c

index ad431d8..45d0c54 100644 (file)
@@ -81,18 +81,19 @@ static const struct watchdog_ops pmic_watchdog_ops = {
 
 static int pmic_wdt_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        int ret;
        struct stpmic1 *pmic;
        struct stpmic1_wdt *wdt;
 
-       if (!pdev->dev.parent)
+       if (!dev->parent)
                return -EINVAL;
 
-       pmic = dev_get_drvdata(pdev->dev.parent);
+       pmic = dev_get_drvdata(dev->parent);
        if (!pmic)
                return -EINVAL;
 
-       wdt = devm_kzalloc(&pdev->dev, sizeof(struct stpmic1_wdt), GFP_KERNEL);
+       wdt = devm_kzalloc(dev, sizeof(struct stpmic1_wdt), GFP_KERNEL);
        if (!wdt)
                return -ENOMEM;
 
@@ -102,15 +103,15 @@ static int pmic_wdt_probe(struct platform_device *pdev)
        wdt->wdtdev.ops = &pmic_watchdog_ops;
        wdt->wdtdev.min_timeout = PMIC_WDT_MIN_TIMEOUT;
        wdt->wdtdev.max_timeout = PMIC_WDT_MAX_TIMEOUT;
-       wdt->wdtdev.parent = &pdev->dev;
+       wdt->wdtdev.parent = dev;
 
        wdt->wdtdev.timeout = PMIC_WDT_DEFAULT_TIMEOUT;
-       watchdog_init_timeout(&wdt->wdtdev, 0, &pdev->dev);
+       watchdog_init_timeout(&wdt->wdtdev, 0, dev);
 
        watchdog_set_nowayout(&wdt->wdtdev, nowayout);
        watchdog_set_drvdata(&wdt->wdtdev, wdt);
 
-       ret = devm_watchdog_register_device(&pdev->dev, &wdt->wdtdev);
+       ret = devm_watchdog_register_device(dev, &wdt->wdtdev);
        if (ret)
                return ret;