tty: fix kernel-doc for {start,stop}_tty
authorJiri Slaby <jslaby@suse.cz>
Wed, 19 May 2021 07:21:53 +0000 (09:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 May 2021 14:59:14 +0000 (16:59 +0200)
Commit f9e053dcfc02 (tty: Serialize tty flow control changes with
flow_lock) renamed start_tty to __start_tty and stop_tty to __stop_tty
and introduced new start_tty and stop_tty. But it left kernel-doc
comments on the old locations:
 tty_io.c:785: warning: expecting prototype for stop_tty(). Prototype was for __stop_tty() instead
 tty_io.c:816: warning: expecting prototype for start_tty(). Prototype was for __start_tty() instead

Fix that by moving the comments to appropriate locations.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210519072153.3859-4-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c

index ad64232..26debec 100644 (file)
@@ -761,6 +761,15 @@ int tty_hung_up_p(struct file *filp)
 }
 EXPORT_SYMBOL(tty_hung_up_p);
 
+void __stop_tty(struct tty_struct *tty)
+{
+       if (tty->flow.stopped)
+               return;
+       tty->flow.stopped = true;
+       if (tty->ops->stop)
+               tty->ops->stop(tty);
+}
+
 /**
  *     stop_tty        -       propagate flow control
  *     @tty: tty to stop
@@ -777,16 +786,6 @@ EXPORT_SYMBOL(tty_hung_up_p);
  *     Locking:
  *             flow.lock
  */
-
-void __stop_tty(struct tty_struct *tty)
-{
-       if (tty->flow.stopped)
-               return;
-       tty->flow.stopped = true;
-       if (tty->ops->stop)
-               tty->ops->stop(tty);
-}
-
 void stop_tty(struct tty_struct *tty)
 {
        unsigned long flags;
@@ -797,6 +796,16 @@ void stop_tty(struct tty_struct *tty)
 }
 EXPORT_SYMBOL(stop_tty);
 
+void __start_tty(struct tty_struct *tty)
+{
+       if (!tty->flow.stopped || tty->flow.tco_stopped)
+               return;
+       tty->flow.stopped = false;
+       if (tty->ops->start)
+               tty->ops->start(tty);
+       tty_wakeup(tty);
+}
+
 /**
  *     start_tty       -       propagate flow control
  *     @tty: tty to start
@@ -808,17 +817,6 @@ EXPORT_SYMBOL(stop_tty);
  *     Locking:
  *             flow.lock
  */
-
-void __start_tty(struct tty_struct *tty)
-{
-       if (!tty->flow.stopped || tty->flow.tco_stopped)
-               return;
-       tty->flow.stopped = false;
-       if (tty->ops->start)
-               tty->ops->start(tty);
-       tty_wakeup(tty);
-}
-
 void start_tty(struct tty_struct *tty)
 {
        unsigned long flags;