Fix a bidirectional UDS connect check typo
authorLukasz Pawelczyk <l.pawelczyk@samsung.com>
Fri, 29 Aug 2014 15:02:54 +0000 (17:02 +0200)
committerCasey Schaufler <casey@schaufler-ca.com>
Fri, 29 Aug 2014 17:10:47 +0000 (10:10 -0700)
The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
bidirectional check that should have checked for mutual WRITE access
between two labels. Due to a typo the second check was incorrect.

Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
security/smack/smack_lsm.c

index 478d99e..00443a9 100644 (file)
@@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
                rc = smk_bu_note("UDS connect", skp, okp->smk_known,
                                        MAY_WRITE, rc);
                if (rc == 0) {
-                       rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
-                       rc = smk_bu_note("UDS connect", okp, okp->smk_known,
+                       rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
+                       rc = smk_bu_note("UDS connect", okp, skp->smk_known,
                                                MAY_WRITE, rc);
                }
        }