net: ethernet: mlx4: Remove unnecessary parentheses
authorVarsha Rao <rvarsha016@gmail.com>
Fri, 1 Jun 2018 02:00:49 +0000 (07:30 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Jun 2018 14:14:39 +0000 (10:14 -0400)
This patch fixes the clang warning of extraneous parentheses, with the
following coccinelle script.

@@
identifier i;
expression e;
statement s;
@@
if (
-(i == e)
+i == e
 )
s

Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
Acked-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/port.c

index 3ef3406..10fcc22 100644 (file)
@@ -614,9 +614,9 @@ int __mlx4_register_vlan(struct mlx4_dev *dev, u8 port, u16 vlan,
                int index_at_dup_port = -1;
 
                for (i = MLX4_VLAN_REGULAR; i < MLX4_MAX_VLAN_NUM; i++) {
-                       if ((vlan == (MLX4_VLAN_MASK & be32_to_cpu(table->entries[i]))))
+                       if (vlan == (MLX4_VLAN_MASK & be32_to_cpu(table->entries[i])))
                                index_at_port = i;
-                       if ((vlan == (MLX4_VLAN_MASK & be32_to_cpu(dup_table->entries[i]))))
+                       if (vlan == (MLX4_VLAN_MASK & be32_to_cpu(dup_table->entries[i])))
                                index_at_dup_port = i;
                }
                /* check that same vlan is not in the tables at different indices */