mtip32xx: Remove superfluous call to pci_disable_msi()
authorAlexander Gordeev <agordeev@redhat.com>
Wed, 19 Feb 2014 08:58:15 +0000 (09:58 +0100)
committerJens Axboe <axboe@fb.com>
Fri, 21 Feb 2014 23:45:26 +0000 (15:45 -0800)
There is no need to call pci_disable_msi() in case
the previous call to pci_enable_msi() failed

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Asai Thambi S P <asamymuthupa@micron.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/mtip32xx/mtip32xx.c

index 5160269..5299a65 100644 (file)
@@ -4615,7 +4615,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,
        if (rv) {
                dev_warn(&pdev->dev,
                        "Unable to enable MSI interrupt.\n");
-               goto block_initialize_err;
+               goto msi_initialize_err;
        }
 
        /* Initialize the block layer. */
@@ -4645,6 +4645,8 @@ static int mtip_pci_probe(struct pci_dev *pdev,
 
 block_initialize_err:
        pci_disable_msi(pdev);
+
+msi_initialize_err:
        if (dd->isr_workq) {
                flush_workqueue(dd->isr_workq);
                destroy_workqueue(dd->isr_workq);