powerpc/powernv: Free name on error in opal_event_init()
authorMichael Ellerman <mpe@ellerman.id.au>
Fri, 20 Sep 2024 09:35:20 +0000 (19:35 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 15 Oct 2024 22:26:50 +0000 (09:26 +1100)
In opal_event_init() if request_irq() fails name is not freed, leading
to a memory leak. The code only runs at boot time, there's no way for a
user to trigger it, so there's no security impact.

Fix the leak by freeing name in the error path.

Reported-by: 2639161967 <2639161967@qq.com>
Closes: https://lore.kernel.org/linuxppc-dev/87wmjp3wig.fsf@mail.lhotse
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/20240920093520.67997-1-mpe@ellerman.id.au
arch/powerpc/platforms/powernv/opal-irqchip.c

index 56a1f7c..d92759c 100644 (file)
@@ -282,6 +282,7 @@ int __init opal_event_init(void)
                                 name, NULL);
                if (rc) {
                        pr_warn("Error %d requesting OPAL irq %d\n", rc, (int)r->start);
+                       kfree(name);
                        continue;
                }
        }