ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_c...
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 16 Nov 2017 10:22:26 +0000 (11:22 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 29 Nov 2017 08:29:41 +0000 (09:29 +0100)
The function "release_firmware" is called in the current implementation of
the function "_request_firmware" after a failure was detected.
Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196
Such a call should therefore not be repeated directly after the
corresponding error information was received in the local variable "err"
of the function "snd_korg1212_create".
Thus remove a misplaced function call.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/korg1212/korg1212.c

index c7b0071..4206ba4 100644 (file)
@@ -2348,7 +2348,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci,
 
        err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev);
        if (err < 0) {
-               release_firmware(dsp_code);
                snd_printk(KERN_ERR "firmware not available\n");
                snd_korg1212_free(korg1212);
                return err;