net: suggest L2 discards be counted towards rx_dropped
authorJakub Kicinski <kuba@kernel.org>
Thu, 31 Dec 2020 03:37:53 +0000 (19:37 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 Jan 2021 00:23:57 +0000 (16:23 -0800)
From the existing definitions it's unclear which stat to
use to report filtering based on L2 dst addr in old
broadcast-medium Ethernet.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/uapi/linux/if_link.h

index 874cc12..82708c6 100644 (file)
@@ -75,8 +75,9 @@ struct rtnl_link_stats {
  *
  * @rx_dropped: Number of packets received but not processed,
  *   e.g. due to lack of resources or unsupported protocol.
- *   For hardware interfaces this counter should not include packets
- *   dropped by the device which are counted separately in
+ *   For hardware interfaces this counter may include packets discarded
+ *   due to L2 address filtering but should not include packets dropped
+ *   by the device due to buffer exhaustion which are counted separately in
  *   @rx_missed_errors (since procfs folds those two counters together).
  *
  * @tx_dropped: Number of packets dropped on their way to transmission,