usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc
authorMa Ke <make_ruc2021@163.com>
Wed, 28 Jun 2023 08:15:11 +0000 (16:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jul 2023 16:18:05 +0000 (18:18 +0200)
We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/fsl_qe_udc.c

index 9c5dc1c..4aae86b 100644 (file)
@@ -1959,6 +1959,8 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value,
        } else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) {
                /* Get endpoint status */
                int pipe = index & USB_ENDPOINT_NUMBER_MASK;
+               if (pipe >= USB_MAX_ENDPOINTS)
+                       goto stall;
                struct qe_ep *target_ep = &udc->eps[pipe];
                u16 usep;