crypto: inside-secure - make the key and context size computation dynamic
authorAntoine Tenart <antoine.tenart@bootlin.com>
Mon, 14 May 2018 13:10:59 +0000 (15:10 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 26 May 2018 16:11:38 +0000 (00:11 +0800)
This patches makes the key and context size computation dynamic when
using memzero_explicit() on these two arrays. This is safer, cleaner and
will help future modifications of the driver when these two parameters
sizes will changes (the context size will be bigger when using AEAD
algorithms).

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/inside-secure/safexcel_cipher.c

index 26f6e05..1f4787e 100644 (file)
@@ -554,13 +554,13 @@ static int safexcel_cipher_cra_exit(struct crypto_tfm *tfm)
 {
        struct safexcel_cipher_ctx *ctx = crypto_tfm_ctx(tfm);
 
-       memzero_explicit(ctx->key, 8 * sizeof(u32));
+       memzero_explicit(ctx->key, sizeof(ctx->key));
 
        /* context not allocated, skip invalidation */
        if (!ctx->base.ctxr)
                return -ENOMEM;
 
-       memzero_explicit(ctx->base.ctxr->data, 8 * sizeof(u32));
+       memzero_explicit(ctx->base.ctxr->data, sizeof(ctx->base.ctxr->data));
        return 0;
 }