ASoC: bcm: cygnus_ssp: remove useless initialization
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 26 Mar 2021 21:59:14 +0000 (16:59 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 31 Mar 2021 17:03:17 +0000 (18:03 +0100)
Cppcheck warning:

sound/soc/bcm/cygnus-ssp.c:1364:6: style: Redundant initialization for
'err'. The initialized value is overwritten before it is
read. [redundantInitialization]
 err = devm_snd_soc_register_component(dev, &cygnus_ssp_component,
     ^
sound/soc/bcm/cygnus-ssp.c:1313:10: note: err is initialized
 int err = -EINVAL;
         ^
sound/soc/bcm/cygnus-ssp.c:1364:6: note: err is overwritten
 err = devm_snd_soc_register_component(dev, &cygnus_ssp_component,
     ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210326215927.936377-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/bcm/cygnus-ssp.c

index 6e634b4..fea296b 100644 (file)
@@ -1310,7 +1310,7 @@ static int cygnus_ssp_probe(struct platform_device *pdev)
        struct device_node *child_node;
        struct resource *res;
        struct cygnus_audio *cygaud;
-       int err = -EINVAL;
+       int err;
        int node_count;
        int active_port_count;