ASoC: SOF: fix string format for errors

These are negative error return values, printing them as hex is annoying
and not beneficial. Switch back to signed type to make error lookup
simpler.

Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210208232149.58899-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/hda-compress.c b/sound/soc/sof/intel/hda-compress.c
index c6cf7b3..fe2f3f7 100644 (file)
--- a/sound/soc/sof/intel/hda-compress.c
+++ b/sound/soc/sof/intel/hda-compress.c
@@ -82,7 +82,7 @@ int hda_probe_compr_set_params(struct snd_sof_dev *sdev,
 
        ret = hda_dsp_stream_hw_params(sdev, stream, dmab, NULL);
        if (ret < 0) {
-               dev_err(sdev->dev, "error: hdac prepare failed: %x\n", ret);
+               dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret);
                return ret;
        }
 

diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index e92e975..72c0b8e 100644 (file)
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -732,7 +732,7 @@ int hda_dsp_resume(struct snd_sof_dev *sdev)
                                ret = snd_hdac_ext_bus_link_power_up(hlink);
                                if (ret < 0) {
                                        dev_dbg(sdev->dev,
-                                               "error %x in %s: failed to power up links",
+                                               "error %d in %s: failed to power up links",
                                                ret, __func__);
                                        return ret;
                                }

diff --git a/sound/soc/sof/intel/hda-loader.c b/sound/soc/sof/intel/hda-loader.c
index d744952..fc25ee8 100644 (file)
--- a/sound/soc/sof/intel/hda-loader.c
+++ b/sound/soc/sof/intel/hda-loader.c
@@ -47,7 +47,7 @@ static struct hdac_ext_stream *cl_stream_prepare(struct snd_sof_dev *sdev, unsig
        /* allocate DMA buffer */
        ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG, &pci->dev, size, dmab);
        if (ret < 0) {
-               dev_err(sdev->dev, "error: memory alloc failed: %x\n", ret);
+               dev_err(sdev->dev, "error: memory alloc failed: %d\n", ret);
                goto error;
        }
 
@@ -58,13 +58,13 @@ static struct hdac_ext_stream *cl_stream_prepare(struct snd_sof_dev *sdev, unsig
        if (direction == SNDRV_PCM_STREAM_CAPTURE) {
                ret = hda_dsp_iccmax_stream_hw_params(sdev, dsp_stream, dmab, NULL);
                if (ret < 0) {
-                       dev_err(sdev->dev, "error: iccmax stream prepare failed: %x\n", ret);
+                       dev_err(sdev->dev, "error: iccmax stream prepare failed: %d\n", ret);
                        goto error;
                }
        } else {
                ret = hda_dsp_stream_hw_params(sdev, dsp_stream, dmab, NULL);
                if (ret < 0) {
-                       dev_err(sdev->dev, "error: hdac prepare failed: %x\n", ret);
+                       dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret);
                        goto error;
                }
                hda_dsp_stream_spib_config(sdev, dsp_stream, HDA_DSP_SPIB_ENABLE, size);

diff --git a/sound/soc/sof/intel/hda-pcm.c b/sound/soc/sof/intel/hda-pcm.c
index 6899341..df00db8 100644 (file)
--- a/sound/soc/sof/intel/hda-pcm.c
+++ b/sound/soc/sof/intel/hda-pcm.c
@@ -111,7 +111,7 @@ int hda_dsp_pcm_hw_params(struct snd_sof_dev *sdev,
 
        ret = hda_dsp_stream_hw_params(sdev, stream, dmab, params);
        if (ret < 0) {
-               dev_err(sdev->dev, "error: hdac prepare failed: %x\n", ret);
+               dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret);
                return ret;
        }
 

diff --git a/sound/soc/sof/intel/hda-trace.c b/sound/soc/sof/intel/hda-trace.c
index 81d76d3..29e3da3 100644 (file)
--- a/sound/soc/sof/intel/hda-trace.c
+++ b/sound/soc/sof/intel/hda-trace.c
@@ -32,7 +32,7 @@ static int hda_dsp_trace_prepare(struct snd_sof_dev *sdev)
 
        ret = hda_dsp_stream_hw_params(sdev, stream, dmab, NULL);
        if (ret < 0)
-               dev_err(sdev->dev, "error: hdac prepare failed: %x\n", ret);
+               dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret);
 
        return ret;
 }
@@ -59,7 +59,7 @@ int hda_dsp_trace_init(struct snd_sof_dev *sdev, u32 *stream_tag)
         */
        ret = hda_dsp_trace_prepare(sdev);
        if (ret < 0) {
-               dev_err(sdev->dev, "error: hdac trace init failed: %x\n", ret);
+               dev_err(sdev->dev, "error: hdac trace init failed: %d\n", ret);
                hda_dsp_stream_put(sdev, SNDRV_PCM_STREAM_CAPTURE, *stream_tag);
                hda->dtrace_stream = NULL;
                *stream_tag = 0;